Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVE] Livechat User Management Improvements #14736

Merged
merged 91 commits into from
Aug 21, 2019
Merged

[IMPROVE] Livechat User Management Improvements #14736

merged 91 commits into from
Aug 21, 2019

Conversation

Hudell
Copy link
Contributor

@Hudell Hudell commented Jun 4, 2019 •
edited by renatobecker-zz
Loading

Closes #14649
Closes #14648
Closes #14740
Closes RocketChat/feature-requests#174

Related to -> https://github.com/RocketChat/Rocket.Chat.Enterprise/pull/55

Important changes and improvements implemented in this PR:

  • Uncoupled the Livechat user management screen, now we have two specific interfaces to manage Manager and Agent roles;
  • Extended the Livechat permissions. We added new permissions to check all Livechat actions, as well as allow/deny access to Livechat management interfaces through the HasPermission validation instead of HasRole;
  • Created LivechatRooms model. We moved the methods related to Livechat stuff from the Rooms model to LivechatRooms model. This is an important and required improvement because we need to be able to extend the LivechatRooms model and overwrite some methods, such as find, findOne, update and so on. This change will improve the maintainability of both Rooms and LivechatRooms as well, reducing the method coupling.
  • Extend filters on Livechat Current Chats. We're now supporting filters for the Livechat Custom Fields as well as Livechat Tags;

@Hudell Hudell changed the title [WIP] Livechat User Managem Improvements [WIP] Livechat User Management Improvements Jun 4, 2019
renatobecker-zz
renatobecker-zz suggested changes Jun 12, 2019
View reviewed changes
Copy link

@renatobecker-zz renatobecker-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's clear the input after adding Agents into Departments as we do on Managers and Agents, what do you think?

@renatobecker
Merge branch 'develop' into new-livechat-features
18b6033 
# Conflicts:
#	app/livechat/client/views/app/livechatManagers.html
#	app/livechat/client/views/app/livechatManagers.js
@renatobecker
Fix singlequote on addSidebarItem params.
358e5c6
@renatobecker
Fix lint rules.
4b5bd14
@renatobecker
Fix lint rules.
183120e
@renatobecker
- Improvements on Livechat Agents list;
d0001d9 
- Improvements on Current Livechats;
@renatobecker
Fix blank line.
43337be
@renatobecker
Fix translations.
a3f7e67
@renatobecker
Merge branch 'develop' into new-livechat-features
bdcfaaf
@renatobecker
Update Livechat methods inside Rooms model, replaced the regular find…
178a611 
…, update and remove methods with permission methods.
@renatobecker
Replace regular find, update and remove methods with permission methods.
e192dcf
@renatobecker
Add LivechatRooms model and replace all Livechat methods in the codeb…
264074d 
…ase.
@renatobecker
Remove permission methods.
1f05b2c
@renatobecker
Remove reference to old Room Model methods.
611ca3a
@renatobecker
Replace Rooms Model to LivechatRooms model on server side.
64aeaef
@renatobecker
Merge branch 'develop' into new-livechat-features
6d7ad8b
@renatobecker
Fix lint rules.
b2fc1c9
@renatobecker
Fiz wrong model.
5481622
@renatobecker
Add input filter in Livechat departments.
7f74dac
rodrigok
rodrigok previously approved these changes Aug 16, 2019
View reviewed changes
renatobecker and others added 16 commits August 16, 2019 23:35
@renatobecker
Fix missed method.
db8be95
@renatobecker
Replace method from Rooms model to LivechatRooms models.
35ff9c4
@renatobecker
Removed unused models.
718d449
@renatobecker
Keep method on Rooms model.
f5ad604
@renatobecker
Merge branch 'develop' into new-livechat-features
88b5136 
# Conflicts:
#	server/startup/migrations/v150.js
@renatobecker
Fix conflicts before merging.
409f394
@renatobecker
Improvement on Livechat Inquiries. Deprecating the agents field.
9f84d87 
The new approach will check departments when the Inquiries are associated to a department.
@renatobecker
Deprecate field agents on Livechat Inquiries. Now we're filtering Inq…
6bb43c0 
…uiries based on department field.
@renatobecker
Merge branch 'develop' into new-livechat-features
b993e70
@renatobecker
Merge branch 'develop' into new-livechat-features
ca75b57 
# Conflicts:
#	server/startup/migrations/v151.js
@sampaiodiego
Merge branch 'develop' into new-livechat-features
f4c8e6c
@sampaiodiego
Change models
3035f97
@sampaiodiego
Add migration
67822b8
@sampaiodiego
Fix migration
36b00eb
@sampaiodiego
Fix models
7bf3df8
@sampaiodiego
Skip permissions tests
cd755d9
@sampaiodiego sampaiodiego merged commit 63d7892 into develop Aug 21, 2019
@sampaiodiego sampaiodiego deleted the new-livechat-features branch August 21, 2019 03:40
@sampaiodiego sampaiodiego mentioned this pull request Sep 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatobecker-zz renatobecker-zz renatobecker-zz requested changes

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@rodrigok rodrigok rodrigok left review comments

Assignees
No one assigned
Labels
squad: omnichannel subj: livechat type: improvement
Projects
None yet
Milestone
2.0.0
7 participants
@Hudell @rodrigok @renatobecker-zz @sampaiodiego @tassoevan @pierre-lehnen-rc @renatobecker